Make SVG standard widths and heights available in the class definition#3197
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3197 +/- ##
=======================================
Coverage 89.62% 89.63%
=======================================
Files 28 28
Lines 31975 31978 +3
Branches 5873 5872 -1
=======================================
+ Hits 28659 28662 +3
Misses 1886 1886
Partials 1430 1430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
I just tacked on another code-duplication removing nit, taking repetitive code out of trees.py to make a standard |
hyanwong
force-pushed
the
svg-nits
branch
2 times, most recently
from
9a718be to
7240db6
Compare
This currently does nothing anyway.
Put a placeholder in, then actually place it on `draw`. This allows the preamble to be (re)set after init but before actually drawing, which can be useful for complex composite drawings.
jeromekelleher
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.